val: centralize log indentation handling - #496
Merged
Merged
Conversation
Treat a leading newline as the marker for a new log record, and keep strings without a leading newline as continuation prints. Move common indentation handling into the VAL logger and PAL print paths. For new log records, skip existing caller-side indentation after '\n', apply the active rule indent, and emit severity prefixes consistently. Clean up legacy call sites that would otherwise bypass the common handling, including trailing-newline-only prints, embedded newline formatting, and direct banner/header prints. No functional test logic changes are intended; this change is limited to logging behavior and output formatting cleanup. Change-Id: I9ee7e226fccbedcc432a6f72f8fa38e8885ad86c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat a leading newline as the marker for a new log record, and keep
strings without a leading newline as continuation prints.
Move common indentation handling into the VAL logger and PAL print paths.
For new log records, skip existing caller-side indentation after '\n',
apply the active rule indent, and emit severity prefixes consistently.
Clean up legacy call sites that would otherwise bypass the common handling,
including trailing-newline-only prints, embedded newline formatting, and
direct banner/header prints.
No functional test logic changes are intended; this change is limited to
logging behavior and output formatting cleanup.
Change-Id: I9ee7e226fccbedcc432a6f72f8fa38e8885ad86c